Hide linked file actions from users who have access to results view #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures looks unrelated |
|
Not sure if we need a new permission or if it should be within the |
Koc
force-pushed
the
feature/add-permission-for-linking-file
branch
2 times, most recently
from
591a0eb
to
1e4ca25
Compare
|
@susnux I've updated PR with reusing already existent |
susnux
approved these changes
Jan 29, 2024
Koc
force-pushed
the
feature/add-permission-for-linking-file
branch
from
1e4ca25
to
e1cfbc7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
============================================
- Coverage 44.79% 44.75% -0.04%
- Complexity 686 687 +1
============================================
Files 59 59
Lines 2697 2699 +2
============================================
Hits 1208 1208
- Misses 1489 1491 +2 |
Chartman123
reviewed
Jan 30, 2024
Chartman123
reviewed
Jan 30, 2024
Chartman123
reviewed
Jan 30, 2024
Koc
force-pushed
the
feature/add-permission-for-linking-file
branch
from
e1cfbc7
to
1abd1fd
Compare
Chartman123
approved these changes
Feb 1, 2024
|
Ok, then just do a rebase and squash the commits into one :) |
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
Koc
force-pushed
the
feature/add-permission-for-linking-file
branch
from
1abd1fd
to
4396fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
Current behavior
Link file/Unlink file/Open filebuttons (but he not allowed to perform this actions due to checks on BE side)Behavior after fix
Screenshots