Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get only forms shared with user from database #2029

Merged
merged 2 commits into from Apr 13, 2024
Merged

Get only forms shared with user from database #2029

merged 2 commits into from Apr 13, 2024

Conversation

Chartman123
Copy link
Collaborator

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added enhancement New feature or request php PHP related ticket labels Mar 23, 2024
@Chartman123 Chartman123 requested a review from susnux March 23, 2024 19:23
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Mar 23, 2024
@Chartman123 Chartman123 self-assigned this Mar 23, 2024
@Chartman123 Chartman123 added this to the 4.2 milestone Mar 23, 2024
@Chartman123 Chartman123 linked an issue Mar 23, 2024 that may be closed by this pull request
Show shared forms (fetching forms that are shared to the user) #2030
Closed
@susnux
Copy link
Collaborator

susnux commented Mar 23, 2024

This does not work for group shares, team shares etc :(

@Chartman123
Copy link
Collaborator Author

Ok... yes, I didn't think about that... and for direct shares I'd need to add share_type = 0...

But wouldn't it be possible to resolve groups/teams with the current user and then also add this to DB query?

@Chartman123 Chartman123 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 23, 2024
@Chartman123
Copy link
Collaborator Author

@susnux I think we could use getUserGroups() for the groups and probeCircles() for teams. and then check if the entries in the shares table for groups/teams are within the returned groups/teams. What do you think?

@Chartman123 Chartman123 marked this pull request as draft March 25, 2024 10:28
@Chartman123 Chartman123 removed this from the 4.2 milestone Mar 28, 2024
susnux
susnux reviewed Mar 29, 2024
View reviewed changes
lib/Db/FormMapper.php Outdated Show resolved Hide resolved
susnux
susnux reviewed Mar 29, 2024
View reviewed changes
lib/Db/FormMapper.php Outdated Show resolved Hide resolved
@Chartman123 Chartman123 added this to the 4.2 milestone Mar 30, 2024
@Chartman123 Chartman123 force-pushed the enh/shared_forms_mapping branch 5 times, most recently from 222ceee to b9aa9a0 Compare April 3, 2024 22:33
@Chartman123 Chartman123 marked this pull request as ready for review April 3, 2024 22:34
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 3, 2024
@Chartman123 Chartman123 requested a review from susnux April 3, 2024 22:34
@Chartman123 Chartman123 force-pushed the enh/shared_forms_mapping branch 5 times, most recently from a3d4403 to 6b8577e Compare April 6, 2024 18:53
@Chartman123
Copy link
Collaborator Author

Thanks for the review. I'm gonna squash the commits and merge it then :)

@Chartman123
Get only forms shared with user from database
b155fc0 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
remove unused variable
26cebe1 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 merged commit e019f14 into main Apr 13, 2024
48 checks passed
@Chartman123 Chartman123 deleted the enh/shared_forms_mapping branch April 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@Chartman123 Chartman123

Labels
3. to review Waiting for reviews enhancement New feature or request php PHP related ticket
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Show shared forms (fetching forms that are shared to the user)
2 participants
@Chartman123 @susnux