Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legacyLink access handling #2060

Merged
merged 1 commit into from Apr 15, 2024
Merged

fix: legacyLink access handling #2060

merged 1 commit into from Apr 15, 2024

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Apr 14, 2024

Without this there are errors in the logs when legacyLink is not set during the migration. In the Form entity, wrong values might get stored if legacyLink is false.

I also switched to the Constants in the migration

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 requested a review from susnux April 14, 2024 19:45
@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews labels Apr 14, 2024
@Chartman123 Chartman123 marked this pull request as ready for review April 14, 2024 19:45
@Chartman123 Chartman123 changed the title fix access_enum migration fix handling legacyLink access handling Apr 14, 2024
@Chartman123 Chartman123 changed the title fix handling legacyLink access handling fix: legacyLink access handling Apr 14, 2024
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@susnux susnux merged commit 3f82fb1 into main Apr 15, 2024
48 checks passed
@susnux susnux deleted the fix/access_migration branch April 15, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with some forms after update to Forms 4.2.0 - spinning wheel with "loading forms"
2 participants