Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lastUpdated on link/unlink file #2066

Merged
merged 2 commits into from Apr 15, 2024
Merged

Set lastUpdated on link/unlink file #2066

merged 2 commits into from Apr 15, 2024

Conversation

Chartman123
Copy link
Collaborator

Currently lastUpdated is not set when a file is (un)linked

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 added the bug Something isn't working label Apr 15, 2024
@Chartman123 Chartman123 requested a review from susnux April 15, 2024 07:44
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Apr 15, 2024
@Chartman123 Chartman123 added this to the 4.2.1 milestone Apr 15, 2024
@susnux
Copy link
Collaborator

susnux commented Apr 15, 2024

Maybe we should just have updated the FormMapper::update method to set always the lastupdated value on update and then call the parent update 🤔

@Chartman123
Copy link
Collaborator Author

Could be done as a refactoring for 4.3

@susnux susnux merged commit eadf4a4 into main Apr 15, 2024
48 checks passed
@susnux susnux deleted the fix/last-updated branch April 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants