Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use prettier for stylistic rules #2143

Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore: Use prettier for stylistic rules #2143

merged 3 commits into from
Jun 12, 2024

Conversation

Chartman123
Copy link
Collaborator

No description provided.

@Chartman123 Chartman123 added 3. to review Waiting for reviews technical debt Technical issue labels May 5, 2024
@Chartman123 Chartman123 requested a review from susnux May 5, 2024 12:47
@Chartman123
Copy link
Collaborator Author

@susnux I followed the setup guide in the prettier-config repo, however, there are some errors ... Could you please have a look at it and adjust the documentation if there's something missing?

@susnux
Copy link
Collaborator

susnux commented May 5, 2024

@susnux I followed the setup guide in the prettier-config repo, however, there are some errors ... Could you please have a look at it and adjust the documentation if there's something missing?

You need to install the eslint configuration:

npm install --save-dev eslint-config-prettier

@Chartman123
Copy link
Collaborator Author

Thanks, that helped :)

@susnux susnux force-pushed the chore/use-prettier branch 2 times, most recently from 042d38b to 75919d9 Compare May 5, 2024 18:55
@susnux susnux force-pushed the chore/use-prettier branch 2 times, most recently from dccc680 to 93444c1 Compare May 6, 2024 12:15
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me, but lets only do this if you agree with the formatting @Chartman123

@Chartman123
Copy link
Collaborator Author

Makes sense for me, but lets only do this if you agree with the formatting @Chartman123

I'll have a closer look at the changes before merging :)

@Chartman123
Copy link
Collaborator Author

@susnux should we wait with merging this PR until @Koc has finished the file question PR? Otherwise there will be lots of merge conflicts I assume...

@Chartman123 Chartman123 force-pushed the chore/use-prettier branch 2 times, most recently from a2c2158 to 1d8d84b Compare May 18, 2024 14:26
Chartman123 and others added 2 commits June 12, 2024 22:15
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@susnux susnux merged commit 5fe16bb into main Jun 12, 2024
51 of 53 checks passed
@susnux susnux deleted the chore/use-prettier branch June 12, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants