Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly label forms lists in the app navigation #2208

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: Correctly label forms lists in the app navigation #2208

merged 1 commit into from
Jun 13, 2024

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Jun 12, 2024

Properly add accessible names (headings) to the sublists in the app navigation.

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Jun 12, 2024
@susnux susnux requested review from Koc and Chartman123 June 12, 2024 22:01
@susnux susnux mentioned this pull request Jun 12, 2024
Merged
Chartman123
Chartman123 reviewed Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this PR there's more space between the new form button and the heading... I think it's too much now.

src/Forms.vue Show resolved Hide resolved
@Chartman123 Chartman123 modified the milestones: 4.2.5, 4.3 Jun 12, 2024
@susnux
fix: Correctly label forms lists in the app navigation
8c21145 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from Chartman123 June 12, 2024 22:50
@susnux
Copy link
Collaborator Author

susnux commented Jun 12, 2024

with this PR there's more space between the new form button and the heading... I think it's too much now.

Fixed ✅

@Chartman123 Chartman123 merged commit 1d503c4 into main Jun 13, 2024
46 checks passed
@Chartman123 Chartman123 deleted the fix/label-navigation branch June 13, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

@Koc Koc Awaiting requested review from Koc

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @Chartman123