Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to OCS API #556

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Move to OCS API #556

merged 1 commit into from
Aug 24, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 11, 2020 •
edited

Move to proper ocs api endpoint

Anything I should edit/improve? Any good habits to have in such case?

@skjnldsv skjnldsv added 2. developing Work in progress enhancement New feature or request labels Aug 11, 2020
@skjnldsv skjnldsv added this to the 2.1 milestone Aug 11, 2020
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2020
Closed
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 11, 2020
jotoeri
jotoeri reviewed Aug 23, 2020
View reviewed changes
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. But seems to work in total.

I stumbled a bit as we moved away from DataResponse to Http\JsonResponse and now go back. But seems to be just what is recommended in docs for ocs api.

lib/Controller/ApiController.php Show resolved Hide resolved
lib/Controller/ApiController.php Outdated Show resolved Hide resolved
lib/Controller/ApiController.php Show resolved Hide resolved
src/components/Questions/AnswerInput.vue Outdated Show resolved Hide resolved
@skjnldsv
Copy link
Member Author

@jotoeri done :)

@skjnldsv skjnldsv requested a review from jotoeri August 24, 2020 08:53
jotoeri
jotoeri approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo see below, CS fix and the commit-history is a bit mixed up now.

But apart from that 👍

src/views/Results.vue Outdated Show resolved Hide resolved
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 24, 2020
@skjnldsv
Move to OCS API
fea3274 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit bd641c5 into master Aug 24, 2020
@skjnldsv skjnldsv deleted the enh/ocs-api branch August 24, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotoeri jotoeri jotoeri approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skjnldsv @jotoeri