This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Fixed too wide selector for the popovermenu #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
rullzer,
MorrisJobke,
jancborchardt and
blizzz
12 tasks
This was interfering with some other menus on the nextcloud app. Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
popovermenu-selector-fix
branch
from
856e92e
to
451c033
Compare
|
Test failure not related to this pr. Master is broken apparently! https://travis-ci.org/nextcloud/gallery/builds |
oparoz
approved these changes
Nov 10, 2017
|
gnah, within vendor/, no wonder ack didn't find that occurence when i was looking for "icon-more" |
|
@blizzz same, my grep exclude was messing with me! 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was interfering with some other menus on the nextcloud server
@nextcloud/javascript @nextcloud/designers