Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the tagger tag main where appropriate #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 26, 2023

That solution is not very awesome, but rather pragmatic. Branch might be left out in the command with "master", but I am not sure about the historic tagging, and lack time for testing.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@nickvergessen
Copy link
Member

DEFAULT_BRANCH=$(git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@')

I use this in my scripts and it works greatly. However in the release org where main is the "frontpage" and not the code and still the default branch that would fail.

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a different way.
There are ways to tag something with the API only

  1. Create a release
  2. Delete the release
  3. See the tag remain

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants