Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trashbin support #99

Closed
hriekehof opened this issue Mar 8, 2018 · 31 comments
Closed

Trashbin support #99

hriekehof opened this issue Mar 8, 2018 · 31 comments
Assignees

Comments

@hriekehof
Copy link

I was not able to find something on this on the web. In Nextcloud 12 when i deleted something from a group folder, it showed up in my personal trashbin and i could restore it.

I recently updated to Nextcloud 13 and now when i delete a file from a group folder it doesn't show up in my personal trashbin anymore.

Is this how its supposed to work ? I really need a way to restore files which were accidentally deleted from group folders.

Thanks for your help

@rogatec
Copy link

rogatec commented Mar 25, 2018

This problem occurs also in Nextcloud 13.

How is everyone handling this issue?
If someone deletes a file in a group folder the file is also gone from the file system.
I am currently using rsync to backup the group folder without --delete parameter

@MorrisJobke MorrisJobke changed the title Trashbin for group folders not working ? Trashbin support Apr 9, 2018
@BloodyIron
Copy link

I've just been testing this app, and honestly, this reason alone makes this app completely a liability for my data.

Consider the following... what if a rogue admin just deletes a group folder? There is no restore, nor file retention, it's just done. What am I supposed to do to protect against this? Or hell, even just accidental "whoops clicked on the wrong one"?

This is COMPLETELY a blocker for me, and I am not going to use this app as a result of this.

This is a useful app in concept, but until this gets addressed, this SIGNIFICANTLY compromises data integrity in the nextCloud ecosystem.

@hriekehof
Copy link
Author

I think its clear that the trashbin is a really needed feature. I'm very happy that someone from nextcloud is working on that :) 👍

@putt1ck
Copy link

putt1ck commented Apr 18, 2018

@MorrisJobke is this an enhancement if some version of the functionality was previously available?

@hriekehof
Copy link
Author

Also in Version 12 the trashbin didn't worked that well. Deleted files only appeard in there for a few minutes. If you forget to restore them directly they were gone.

@putt1ck
Copy link

putt1ck commented Apr 22, 2018

@icewind1991 let me know if there's anything we can do to help

@BloodyIron
Copy link

Well, for me, I just started trialing the app. Since it has no trashbin tie-in, it breaks the whole restore ecosystem baked into nextCloud. As far as I'm concerned, this is new functionality that is needed.

@gtchm
Copy link

gtchm commented Apr 24, 2018

This is EXTREMELY severe. Is it possible to have an ETA for a fix?

@BloodyIron
Copy link

I agree that this is extremely severe.

@putt1ck putt1ck added the bug label Apr 27, 2018
@gtchm
Copy link

gtchm commented May 3, 2018

At least, can we have a popup that warns for content being forever deleted?

@BloodyIron
Copy link

@gtchm while I understand why you propose such a thing, I must disagree with it on principle. I think it makes the breaking of the trash bin functionality acceptable. IMO, the fact group folders CAN break the trash bin functionality is a serious problem in-and-of-itself, as it breaks the consistent experience users generally would come to expect.

Adding a warning can make developers complacent about the discrepancy of features, that IMO shouldn't exist in the first place.

A user should NEVER have to worry about whether the trash bin works for the scope they are working in or not.

@gtchm
Copy link

gtchm commented May 3, 2018

I understand what you are saying, but I believe we need urgent action on this matter to preserve the usability of this software, which I love, but w/out being able to retrieve accidentally deleted data, it is not usable. Unfortunately I'm not a programmer so I cannot help, but heck, I would be willing to pay to get this sorted. I have no clue on how this work in this community, so I'm asking genuinely... should we put like $50 each so the developer can invest time to fix this problem?

@pascalBokBok
Copy link

scary stuff. What is the timespan on getting the trashbin?
We will have to migrate back to non-group folders for now.

@zippytiff
Copy link

hi, just wondering how active this app is?

I just had a deep bug on passwords and i was fixed within 24 hours

ZT

@terrar
Copy link

terrar commented Jul 18, 2018

Is there a timeline when trashbin and notification will work again?
I would really need this.

@terrar
Copy link

terrar commented Jul 26, 2018

really?
not to answer is the best way to handle this bug?

@pascalBokBok
Copy link

@terrar , As another user I can say that mounting a folder on the server as external storage (local) instead solved our problem with missing trashbin and versions. That will basically give you the same as the group folder.

@ArnY
Copy link

ArnY commented Jul 27, 2018

Hello,

Nextcloud is working on it. It requires deep changes. They are planning to release those with NC 15.

RuudschMaHinda added a commit that referenced this issue Sep 19, 2018
Since this is an official app, potential users should know about those changes to normal behaviour because it changes the workflow and subverts expectations of what the user is used to. Which might lead to trouble with users - especially when changing from normal shares to group folders, and suddenly the clients don't sync.
Addresses #112 #103 #99
@icewind1991
Copy link
Member

Trashbin and versioning support is currently in master and should work with the latest NC15 rc.

@Nils160988
Copy link

Latest Master together with NC 15RC1 works!

@hriekehof
Copy link
Author

Works for me too now 👍

@winstonford
Copy link

version 15.0.2

I moved a group folder, got 423 lock errors, and the trash immediately grew to consume all disk space:
/var/snap/nextcloud/common/nextcloud/data/__groupfolders/trash/2
19.7 GiB [##########]

doing
nextcloud.occ trashbin:cleanup
does not empty the above trash.

How do I empty group trash?

@winstonford
Copy link

One of my machines just connected, begin to sync, and group folders trash instantly grew by 2gb.

/var/snap/nextcloud/common/nextcloud/data/__groupfolders/trash/2
21.9 GiB [##########]

@dirkpape
Copy link

this happens for me to. Version 15.0.4

One of my machines just connected, begin to sync, and group folders trash instantly grew by 2gb.

/var/snap/nextcloud/common/nextcloud/data/__groupfolders/trash/2
21.9 GiB [##########]

this happens for me, too.

@Beeez
Copy link

Beeez commented Jun 18, 2019

Is this a thing at all yet? I had ran out of storage due to a Group Folders trash bin becoming full.

@biva
Copy link

biva commented Nov 12, 2019

@icewind1991 I see new messages after this issues has been closed. I hesitate to use GroupFolders in my NC instance, but those messages are showing remaining important issues regarding the trash management: is it really solved? Thanks

@feutl
Copy link

feutl commented Jan 22, 2020

Seems still not properly integrated.
trashbin_retention_obligation does not work for group folders which is not good and fills up the disk.

@mesiah1970-haydar
Copy link

Hello and Good morning,

yes I agree, the group folders trashbin should expire. Maybe we can achieve this with a extra option in the group folder app, or create a new group folder occ command. It could be something simple, which could help people to get out of the trashbin mess. Please help us!

Rgds

Haydar

@ntinti
Copy link

ntinti commented Mar 12, 2020

Any news about this?

@mesiah1970-haydar
Copy link

unfortunately not, depends when the developers have time. I cannot accuse them, since they are definitely involved in other projects. Maybe one of them has mercy about us;-)

@SimJoSt
Copy link
Contributor

SimJoSt commented May 12, 2020

There is a separate issue for this here: #345
Please post comments and experiences regarding this there.

@nextcloud nextcloud locked as off-topic and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests