Fix #801 Folder icon in shared group folder #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always set icon for group folder via ContentLoaded event to have it also in a shared folder. Signed-off-by: Johannes Kreuzer <Johannes@kreuzer-bb.de>
Removed duplicate code in registration in the file list plugin as suggested by @juliushaertl Signed-off-by: Johannes Kreuzer <johannes@kreuzer-bb.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/490
branch
from
453e11c
to
5b2adbd
Compare
ChristophWurst
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always set icon for group folder via ContentLoaded event to have it also in a shared folder.
Based on #1235 but added a commit in order to make sure that the files app integration is properly loaded on public pages with the new events to embed scripts.