Add tooltip for user/group name in sidebar ACL list #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole string needs to be internationalized using a placeholder to ensure that it can be properly translated. Signed-off-by: Daniel Calvi帽o S谩nchez <danxuliu@gmail.com>
The available space in the table may not be enough to show the full name, so in some cases it was not possible to distinguish between two different names. Signed-off-by: Daniel Calvi帽o S谩nchez <danxuliu@gmail.com>
|
/backport to stable21 |
|
/backport to stable20 |
juliushaertl
approved these changes
Mar 2, 2021
juliushaertl
deleted the
add-tooltip-for-user-group-name-in-sidebar-acl-list
branch
This was referenced Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available space in the table may not be enough to show the full name, so in some cases it was not possible to distinguish between two different names.
Besides that the display name is no longer concatenated but internationalized as a whole to ensure that it can be properly translated (which, unfortunately, will temporary cause the UI string to be shown in English until the new string is translated 馃し).