Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quota bar appearance #2341

Merged
merged 1 commit into from May 1, 2023
Merged

Fix quota bar appearance #2341

merged 1 commit into from May 1, 2023

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Apr 19, 2023

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

fixes #2332

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! For accessibility reasons, I would suggest that the text color be changed to --color-main-text, other than that it is very nice!

image

image

@Jerome-Herbinet
Copy link
Member Author

Looks great overall! For accessibility reasons, I would suggest that the text color be changed to --color-main-text, other than that it is very nice!

image

image

Done @nimishavijay :-)

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 :)

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Change text color

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Fix quota bar appearance

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@solracsf solracsf added the 3. to review Items that need to be reviewed label Apr 30, 2023
@solracsf
Copy link
Member

/backport to stable26

@solracsf
Copy link
Member

/backport to stable25

@icewind1991 icewind1991 merged commit 2c1b4f2 into master May 1, 2023
8 checks passed
@icewind1991 icewind1991 deleted the Jerome-Herbinet-patch-1 branch May 1, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumed quote indicator broken
4 participants