fix: Include admin group in list of all groups
#2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `admin` group should be able to be added as a group folder member Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to stable25 |
|
/backport to stable26 |
icewind1991
approved these changes
May 1, 2023
This was referenced May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adminto groupfolder anymore #2203Currently the
admingroup is not automatically added as a member group to a new folder, so users of theadmingroup can not access group folders.Moreover the
admingroup can currently not be added as a member because it is filtered from the list of available groups.This PR simply removes that filter, as I think adding
admingroup as a member should be done explicitly, also the other way round we would need to add it to the member groups by default and add it to all existing group folders.