Check for folder existence in FolderController #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
bug
help wanted
backport-request
3. to review
juliushaertl
requested changes
May 10, 2023
Co-authored-by: Julius H盲rtl <jus@bitgrid.net> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
juliushaertl
approved these changes
May 10, 2023
|
/backport to stable26 |
|
/backport to stable25 |
1 task
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on customer bug report: all folder changes requests return a success, even if the folder doesn't exist.
Added a private method based on already existing code, to return 404 if folder is not exist.
Sorry for my poor PHP-knowledge, i did the best i could 馃檭 Please feel free to suggest changes or edit by yourself.