New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readdir() call in loop with undesirable false evaluation potential #2416

Merged

icewind1991 merged 1 commit into nextcloud:master from joshtrichards:jr-readdir-false-false

Jun 7, 2023

Member

joshtrichards commented Jun 3, 2023

Fixes a readdir() call within a loop that had undesirable false evaluation potential in:

opendir() in OCA\GroupFolders\ACL\ACLStorageWrapper

Same deal as nextcloud/server#38630

Ref: https://www.php.net/manual/en/function.readdir.php


          Fix readdir() call in loop with undesirable false evaluation potential

7b56a7f

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

solracsf added the 3. to review label

icewind1991 approved these changes

View reviewed changes

icewind1991 merged commit bfa0dfc into nextcloud:master

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment