Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ACL): don't put inherited ACL permissions in the propPatch request payload #2660

Merged
merged 1 commit into from Dec 18, 2023
Merged

fix(ACL): don't put inherited ACL permissions in the propPatch request payload #2660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/SharingSidebarView.vue
View file
Open in desktop
Expand Up @@ -309,7 +309,7 @@ export default {
const rule = new Rule()
rule.fromValues(option.type, option.id, option.displayname, 0b00000, 0b11111)
this.list.push(rule)
client.propPatch(this.model, this.list).then(() => {
client.propPatch(this.model, this.list.filter(rule => !rule.inherited)).then(() => {
this.showAclCreate = false
})
},
Expand All @@ -319,7 +319,7 @@ export default {
if (index > -1) {
list.splice(index, 1)
}
client.propPatch(this.model, list).then(() => {
client.propPatch(this.model, list.filter(rule => !rule.inherited)).then(() => {
this.list.splice(index, 1)
const inheritedAcl = this.inheritedAclsById[rule.getUniqueMappingIdentifier()]
if (inheritedAcl != null) {
Expand Down Expand Up @@ -347,7 +347,7 @@ export default {
}
item.inherited = false
Vue.set(this.list, index, item)
client.propPatch(this.model, this.list).then(() => {
client.propPatch(this.model, this.list.filter(rule => !rule.inherited)).then(() => {
// TODO block UI during save
})
},
Expand Down