Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: cannot create guest #699

Closed
PVince81 opened this issue Aug 5, 2021 · 4 comments
Closed

Regression: cannot create guest #699

PVince81 opened this issue Aug 5, 2021 · 4 comments
Assignees
Labels
bug Something isn't working regression Regression of a previous working feature

Comments

@PVince81
Copy link
Member

PVince81 commented Aug 5, 2021

Route issue on master:
image

@PVince81 PVince81 added bug Something isn't working regression Regression of a previous working feature labels Aug 5, 2021
@PVince81 PVince81 self-assigned this Aug 5, 2021
@PVince81
Copy link
Member Author

PVince81 commented Aug 5, 2021

okay, so this looks more like a server issue, because in the guests app we still have the old router.

this is the line where it happens: https://github.com/nextcloud/guests/blob/master/src/views/GuestForm.vue#L185

now, if the guests app would be using its own router, it would work fine.
however it seems the router is using some global instance, which means that now every app using the old router will break in the same way and needs adjusting

@PVince81
Copy link
Member Author

PVince81 commented Aug 5, 2021

  • update router in guests app
  • fix router usage to match v2
  • set min-version + max-version in info.xml to 23
  • increase major version to 3.0
  • need a release for master / 3.0
  • create branch stable2 from the commit before the above
    • set max-version to 22 there
    • need a release for stable2 so that people don't get into a breaking state when updating

@PVince81
Copy link
Member Author

PVince81 commented Aug 6, 2021

Fix for master was added to the router update PR: #603

@PVince81
Copy link
Member Author

PVince81 commented Aug 6, 2021

mystery solved, see #603 (comment)

@PVince81 PVince81 closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

1 participant