Allow the app to run with NC 21 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PHP 7.2 is not supported by NC server master any more Adjusted ap name in phpunit.xml and a few whitespaces. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
|
I've removed PHP 7.2 from CI as it's using NC master which doesn't support it any more. |
|
not sure where that pending "php7.2-mysql-master" comes from :-/ |
|
removed, it was set as "require to pass" for the branch protection on github |
icewind1991
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a quick test with server master (4d974d02f20246afb9e8e4f9b756fb0a5d161408) and the following worked for me:
(I needed this locally to test some stuff with talk)