New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to IBootstrap #702
Move to IBootstrap #702
Conversation
so now I've moved everything to the now, while testing:
|
I've tested on master and on that branch IUserSession->getUser() returns non-null, so the problem is specific to the move to IBootstrap. So I'll debug deeper to find out when the latter is actually getting populated and why it's not in Edit: solved, I mixed up the initialization order: 23c292b |
This makes sure that the late setup is correctly running and removes the hack where it was added to routes.php. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
where possible... Signed-off-by: Vincent Petry <vincent@nextcloud.com>
As a first step to move to using the IBootstrap contexts, this reduces the number of calls to $this->container to make it easier to move to the proper context's container once ready. Deleted unused private functions. Inlined functions that were only used once. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Move initialization code to boot() and use the provided contexts. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
This way the user from the session can be properly resolved. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
23c292b
to
35be9c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🐘
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
This makes sure that the late setup is correctly running and removes the
hack where it was added to routes.php.