Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add persistence settings for redis #546

Closed
f3k-freek opened this issue Mar 28, 2024 · 2 comments · Fixed by #549
Closed

Feature: Add persistence settings for redis #546

f3k-freek opened this issue Mar 28, 2024 · 2 comments · Fixed by #549
Labels
enhancement New feature or request

Comments

@f3k-freek
Copy link
Contributor

Description of the change

Add persistence settings for the redis database. Such as storageClass and wether it should be enabled at all.

Benefits

  • It would be possible to use a different storageClass than default which would enable:
    • different type of storage
    • different backup settings
    • etcetera
  • It would be possible to disable persistent storage. Since redis is only used as cache. One might opt to not use persistent storage at all.

Possible drawbacks

  • I can't think of any.
@f3k-freek f3k-freek added the enhancement New feature or request label Mar 28, 2024
@jessebot
Copy link
Collaborator

Thanks for submitting a feature request :)

You can use any persistence settings you find the bitnami docs here:
https://github.com/bitnami/charts/tree/main/bitnami/redis

The way the helm chart works, the bitnami redis helm chart is a subchart, so we pass through anything under the redis parameter in the values.yaml through to that chart. If you'd like, you can submit a PR to add those settings to our values.yaml just so that people are aware of them. If you do, please remember to bump the chart version and update the README in the charts/nextcloud directory, so that everyone can benefit.

@f3k-freek
Copy link
Contributor Author

Thank you for your fast reply.
I have submitted a PR as you proposed: #549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants