Sets OVERWRITEPROTOCOL env var in deployement.yaml for http to https redirect to work

[wethinkagile]

Pull Request

Description of the change

Problem
The polling URL does not start with HTTPS despite the login URL started with HTTPS. Login will not be possible because this might be a security issue. Please contact your administrator

Solution
Sets OVERWRITEPROTOCOL env var in deployement.yaml in case user has http to https redirect in ingress annotations

Benefits

Fixing the Issue in the Helm Chart.

Possible drawbacks

None known.

Applicable issues

• fixes https://help.nextcloud.com/t/desktop-client-is-trying-to-use-http-instead-of-https/122288/26

Additional information

To fix the HTTPS redirect issue in case you use http to https redirect in ingress annotations, use in values.yaml:

phpClientHttpsFix:
  enabled: true
  protocol: https

This sets OVERWRITEPROTOCOL env variable in deployment.yaml accordingly to https.

Checklist

• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Variables are documented in the README.md

[tvories]

@stevek-pro can you sign off on the DCO and bump the chart version?

Thanks!

[wethinkagile]

@tvories I did bump twice now, is there another bump necessary? About the DCO, I did sign with "commit -S -m", I'm not quite sure what's wrong. But I will try.

[tvories]

@stevek-pro Yeah, I merged a bunch of PRs yesterday so unfortunately, the version changed a lot. I believe the current version should be 2.13.2. To sign off, follow the instructions here:

https://github.com/nextcloud/helm/pull/210/checks?check_run_id=5587753976

[wethinkagile]

@tvories Thank you, I did all the necessary steps. Also my error on the DCO, I mixed this PR up with one from another repo.