-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to have sections and add existingSecret for mariadb, postgresql, and redis #359
Update docs to have sections and add existingSecret for mariadb, postgresql, and redis #359
Conversation
…gresql, and redis Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
a5d605e
to
7d49092
Compare
The changes to README are big enough that it might make sense to just look at it here: |
@tvories or @provokateurin could you please have a look at this when you have some free time? It would help in making the docs more navigable and adding in the some commonly asked for features of existing secrets for external charts. The doc update is in this PR as well because we need to start separating out the docs to point to exact things in it, at least until my onboarding calms down to my current company and I can dedicate some time to working on a proper doc site for the helm chart (because it's a massive chart, and the readme will eventually get too big). |
@jessebot What is the status of this? |
It just needs a rebase, but then it can be merged since I approved the changes. |
Signed-off-by: JesseBot <jessebot@linux.com>
Sorry for the delay. I've been really busy at work. Just fixed the helm chart version, and after the checks run, I will merge this. |
@jessebot Thank you! |
Pull Request
Description of the change
Adding
exsitingSecret
parameters for MariaDB, PostgreSQL, and Redis.Also updating docs to:
Benefits
Gives README a much needed face lift to make it easier to find stuff. Allows people to use existing secrets by default for all our services.
Possible drawbacks
🤷
Applicable issues
Checklist
Chart.yaml
according to semver.