Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to have sections and add existingSecret for mariadb, postgresql, and redis #359

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Mar 4, 2023

Pull Request

Description of the change

Adding exsitingSecret parameters for MariaDB, PostgreSQL, and Redis.

Also updating docs to:

  • make it easier to link to sections of the configuration by separating out:
  • database config params
    • added new exsitingSecret params for both mariadb/postgres
  • persistence config params
  • metrics config params
  • add redis existingSecret params
  • update supported versions of k8s (we can't support 1.10-1.19 as they are not even in support by k8s anymore)
  • update/add links to bitnami helm charts (they use main instead of master branch now)

Benefits

Gives README a much needed face lift to make it easier to find stuff. Allows people to use existing secrets by default for all our services.

Possible drawbacks

🤷

Applicable issues

Checklist

…gresql, and redis

Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
@jessebot jessebot force-pushed the feature-add-existing-secrets branch from a5d605e to 7d49092 Compare March 4, 2023 12:21
@jessebot
Copy link
Collaborator Author

jessebot commented Mar 4, 2023

The changes to README are big enough that it might make sense to just look at it here:
https://github.com/nextcloud/helm/blob/7d490927c84f95f450e8c847c1205f711e60e396/charts/nextcloud/README.md

@jessebot
Copy link
Collaborator Author

@tvories or @provokateurin could you please have a look at this when you have some free time? It would help in making the docs more navigable and adding in the some commonly asked for features of existing secrets for external charts. The doc update is in this PR as well because we need to start separating out the docs to point to exact things in it, at least until my onboarding calms down to my current company and I can dedicate some time to working on a proper doc site for the helm chart (because it's a massive chart, and the readme will eventually get too big).

@Nils98Ar
Copy link

@jessebot What is the status of this?

@provokateurin
Copy link
Member

It just needs a rebase, but then it can be merged since I approved the changes.

Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot
Copy link
Collaborator Author

Sorry for the delay. I've been really busy at work. Just fixed the helm chart version, and after the checks run, I will merge this.

@jessebot jessebot merged commit e37c3cc into nextcloud:master Apr 10, 2023
2 checks passed
@jessebot jessebot deleted the feature-add-existing-secrets branch April 10, 2023 11:24
@jessebot jessebot mentioned this pull request Apr 10, 2023
@Nils98Ar
Copy link

Sorry for the delay. I've been really busy at work. Just fixed the helm chart version, and after the checks run, I will merge this.

@jessebot Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: existingSecret for redis and mariadb deployment
3 participants