fix(metrics-image): add pullSecrets #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix DCO and chart version. |
Signed-off-by: Tobias Heinzmann <heinzmann.extern@univention.de>
tarhann
force-pushed
the
fix/metrics-image-pullsecrets
branch
from
0bc1bb6
to
b05595d
Compare
Signed-off-by: Tobias Heinzmann <heinzmann.extern@univention.de>
provokateurin
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
metrics-deplyoment image was missing pullSecrets as they are applicable for all container images in the chart.
Benefits
Now the image of the metrics exporter can be provided by an private container registry.
Applicable issues
fixes metrics-deployment does not contain imagePullSecrets #381
DCO has been signed off on the commit.
Chart version bumped in
Chart.yamlaccording to semver.(optional) Variables are documented in the README.md