Add nginx startup probe #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx was missing startupProbe for some reason Signed-off-by: Piotr Maksymiuk <50323052+ishioni@users.noreply.github.com>
Signed-off-by: Piotr Maksymiuk <50323052+ishioni@users.noreply.github.com>
|
@jessebot Could you take a look? |
1 task
|
@provokateurin Can this be merged please? |
provokateurin
approved these changes
Jun 27, 2023
|
@ishioni Please resolve the conflict, I will merge afterwards. |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Piotr Maksymiuk <50323052+ishioni@users.noreply.github.com>
Signed-off-by: Piotr Maksymiuk <50323052+ishioni@users.noreply.github.com>
|
@provokateurin Done |
|
Ah I just saw you merged the main branch into this one. Please rebase onto the main branch next time, it results in cleaner git history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Add startupProbe to nginx. For some reason it was missing compared to the apache version
Benefits
Both types support the same range of probes
Possible drawbacks
none?
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.