README updates: Add occ command examples; Clean up readme tables; Clean up branding; change supported k8s version #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixing Nextcloud branding and bumping supported version of k8s Signed-off-by: jessebot <jessebot@linux.com>
jessebot
force-pushed
the
chore/clean-readme-add-occ-doc
branch
from
bacf26f
to
a8038a8
Compare
provokateurin
requested changes
Jul 12, 2023
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: JesseBot <jessebot@linux.com>
|
You forgot to change the other examples, otherwise LGTM |
jessebot
commented
Jul 12, 2023
jessebot
commented
Jul 12, 2023
…mples to be /bin/sh Signed-off-by: JesseBot <jessebot@linux.com>
|
@provokateurin sorry about that! Fixed and ready for approval :) |
provokateurin
requested changes
Jul 12, 2023
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: JesseBot <jessebot@linux.com>
provokateurin
approved these changes
Jul 12, 2023
raynay-r
pushed a commit
to raynay-r/nextcloud-helm
that referenced
this pull request
Apr 16, 2024
…an up branding; change supported k8s version (nextcloud#414) * Add occ command examples; Clean up readme tables also fixing Nextcloud branding and bumping supported version of k8s Signed-off-by: jessebot <jessebot@linux.com> * Use shell instead of bash in occ example; fix grammar Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: jesseBot <jessebot@linux.com> * Apply suggestions from code review - fixing rest of the /bin/bash examples to be /bin/sh Signed-off-by: jesseBot <jessebot@linux.com> * Apply suggestions from code review - more grammar fixes :) Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: jesseBot <jessebot@linux.com> --------- Signed-off-by: jessebot <jessebot@linux.com> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Benefits
Just helps make the readme a bit more presentable and also adds another tidbit of info for those looking to run occ commands.
Possible drawbacks
🤷 I'm open to feedback
Applicable issues
for the occ part:
#45
it's also come up in two discussions:
#301
#352
Additional information
Checklist
Chart.yamlaccording to semver.