Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #469

Merged
merged 6 commits into from Nov 13, 2023
Merged

Conversation

jessebot
Copy link
Collaborator

Pull Request

Description of the change

This adds a little contributing doc that we can update over time as we need.

Benefits

This should show up on the side panel of the repo, and makes it easier to link. Some users familiar with CONTRIBUTING.md docs will check for this before submitting a PR.

Possible drawbacks

None that I can think of

Applicable issues

none that I can remember

Additional information

none that I can think of

Checklist

Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot jessebot mentioned this pull request Nov 13, 2023
1 task
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I just have some nitpicks

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
jessebot and others added 3 commits November 13, 2023 13:41
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: JesseBot <jessebot@linux.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: JesseBot <jessebot@linux.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot
Copy link
Collaborator Author

thank you! :)

@provokateurin
Copy link
Member

Can you squash?

@jessebot jessebot merged commit df7ffeb into nextcloud:main Nov 13, 2023
1 check passed
@jessebot jessebot deleted the add-contributing-doc branch November 13, 2023 12:42
@jessebot
Copy link
Collaborator Author

Can you squash?

oop, missed this, but yeah, the default strategy is squash and merge for me :)
https://github.com/nextcloud/helm/commits/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants