Update release.yaml - only run release on charts directory changes #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JesseBot <jessebot@linux.com>
provokateurin
approved these changes
Nov 13, 2023
delete-merged-branch
bot
deleted the
only-run-release-on-charts-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Accidentally kicked off a release when I added the contributing doc, so this should stop that from happening the future.
Benefits
This changes
paths-ignoreto justpathsand then the path is anything under the charts dir.Possible drawbacks
If there's a change to ONLY the README in the charts dir, it would still attempt a release and fail, but I think the best thing to do longer term is make the README autogenerated via something like helm-docs and move all the other docs currently in the charts/nextcloud/README to the root level readme, but this is also going to be fairly rare, so I'm up for debate :)
Applicable issues
none
Additional information
we could also just add CONTRIBUTING.md and CODE_OF_CONDUCT.md to the paths-ignore. Happy to do that instead :)
Checklist
Chart.yamlaccording to semver.