Logging documentation update (#443) #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Veymax <mcder018@live.com>
jessebot
reviewed
Nov 22, 2023
jessebot
reviewed
Nov 22, 2023
jessebot
reviewed
Nov 22, 2023
jessebot
reviewed
Nov 22, 2023
jessebot
reviewed
Nov 22, 2023
|
Thanks for doing this! Looks good. There's just a few minor nitpicks :) |
Rolling in suggestions Co-authored-by: JesseBot <jessebot@linux.com> Signed-off-by: Maximilien McDermott <mcder018@live.com>
Signed-off-by: Veymax <mcder018@live.com>
|
Done! And happy to. Hope this will help folks in the future |
jessebot
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Adds information on how to enable logging and retrieve those logs, as well as a reminder to anonymize
Benefits
Ability to point to this section in the README in our issue template as well as in any other issues when users would like to know how to get more detailed logs. Saves typing :)
Possible drawbacks
None that I can think of
Applicable issues
Additional information
Don't think there's anything extra
Checklist
Chart.yamlaccording to semver. - no need, doc update