render ingress according to supported apiVersion #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Maksymiuk <piotr.maksymiuk@movishell.pl>
|
@ishioni Thanks for this PR - I'm curious what else needs to be done for NC21 support in this helm chart ? |
For 21 itself - nothing. It could be switched to now (I'm already running it). But the high performance backend needs a second container in the pod and will need to placed behind a path prefix. Hence the addition of that into the ingress |
Signed-off-by: Piotr Maksymiuk <piotr.maksymiuk@movishell.pl>
Signed-off-by: Piotr Maksymiuk <piotr.maksymiuk@movishell.pl>
tvories
reviewed
Mar 3, 2021
|
|
||
| {{- define "nextcloud.ingress.apiVersion" -}} | ||
| {{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.GitVersion -}} | ||
| {{- print "extensions/v1beta1" -}} |
There was a problem hiding this comment.
nice, I like that you handled the check for previous versions
There was a problem hiding this comment.
I take no credit for the method, but I don't remember who I got the idea from (probably k8s-at-home common lib)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Renders the ingress resource according to newest supported apiVersion
Benefits
networking.k8s.io/v1beta1 is going away soon. This also lays the groundwork for supporting High Performance Back-end in NC21
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.