Lazy load dashboard widget and reference widgets #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
juliushaertl
reviewed
Feb 8, 2023
| @@ -11,17 +9,17 @@ | |||
| * @copyright Julien Veyssier 2020 | |||
| */ | |||
|
|
|||
| import Vue from 'vue' | |||
| import './bootstrap.js' | |||
There was a problem hiding this comment.
Is bootstrap gone and not needed anymore or is this removed by accident?
There was a problem hiding this comment.
boostrap is basically replaced by Vue.mixin({ methods: { t, n } })
juliushaertl
approved these changes
Feb 10, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make it so only one file per chunk would be generated but I still don't get it. Anyway, leaving the Webpack
optimizationconfig empty just works fine, leaving it do a split storm 馃榿.So, this works fine. Any objection to leave
optimizationempty?