Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side configurable menu not shown #129

Closed
MorrisJobke opened this issue Mar 22, 2017 · 24 comments
Closed

Server side configurable menu not shown #129

MorrisJobke opened this issue Mar 22, 2017 · 24 comments
Assignees
Milestone

Comments

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 22, 2017

  • clicking on the logo doesn't reveal the server side menu
  • app: 2.17.00031 (nightly)

On the server I installed the external app and configured some menu entries (I used the cleanup branch by @nickvergessen nextcloud/external#1)

curl https://drake.weasel.rocks/ocs/v2.php/apps/external/api/v1 -u USER:PASSWORD
<?xml version="1.0"?>
<ocs>
 <meta>
  <status>ok</status>
  <statuscode>200</statuscode>
  <message>OK</message>
 </meta>
 <data>
  <element>
   <id>2</id>
   <name>Google</name>
   <url>https://google.com</url>
   <lang></lang>
   <icon>https://drake.weasel.rocks/apps/external/img/external.svg</icon>
  </element>
  <element>
   <id>3</id>
   <name>NYT</name>
   <url>https://newyorktimes.com</url>
   <lang>en</lang>
   <icon>https://drake.weasel.rocks/apps/external/img/external.svg</icon>
  </element>
 </data>
</ocs>

@marinofaggiana What else is needed?

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 22, 2017

Please @MorrisJobke install this on my test server https://ios-demo.weasel.rocks or create a user for me on https://drake.weasel.rocks

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 22, 2017

https://drake.weasel.rocks/apps/external/img/external.svg

no svg, if this API is for client the SVG is not supported, please make API for device not for web base

@mario
Copy link
Contributor

mario commented Mar 22, 2017

Just wondering ... have you tried SVGKit?

@marinofaggiana
Copy link
Member

@mario

schermata 2017-03-22 alle 11 32 57

Result :

1

@mario
Copy link
Contributor

mario commented Mar 22, 2017

@marinofaggiana ah, fun :)

@mario
Copy link
Contributor

mario commented Mar 22, 2017

Well, as a short-term solution you could load them in a small, borderless webview - that would work, right? :)

@marinofaggiana
Copy link
Member

hahaah beautiful !! SVG hates me :(

@mario
Copy link
Contributor

mario commented Mar 22, 2017

It does not - if you load a SVG via a super-small webview, it should work :)

@marinofaggiana
Copy link
Member

@mario but in Android ?

@mario
Copy link
Contributor

mario commented Mar 22, 2017

@marinofaggiana I should be able to use SVG since we already have a PR that loads SVG images in an imageview, and I'll figure a way out for the actual notifications (not the screen, that's easy).

@marinofaggiana
Copy link
Member

@mario i have a class with UIImageView and I do not want change it

@mario
Copy link
Contributor

mario commented Mar 22, 2017

@marinofaggiana :D That's all nice, but we need a solution - and webview gives a solution, even if a hacky one :)

@marinofaggiana
Copy link
Member

Change API :D jokes apart, work so It tough, too time-consuming for analysis performed without asking me anything ...

@mario
Copy link
Contributor

mario commented Mar 22, 2017

Just dropping alternatives ... webview is a known and tested one. If you want "easier", see:
https://github.com/exyte/Macaw/wiki/Render-SVG-file

@marinofaggiana
Copy link
Member

now I try ...

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 22, 2017

🙈

schermata 2017-03-22 alle 12 51 42

@MorrisJobke
Copy link
Member Author

Please @MorrisJobke install this on my test server https://ios-demo.weasel.rocks

Done. I added 1 entry in "All languages" and one for english, german and italian.

@marinofaggiana
Copy link
Member

I'm not sure that the all languages are correct .. for example :

iOS: pt-BR, Server : pt_BR !?
Chinese ... etc.

@MorrisJobke
Copy link
Member Author

I'm not sure that the all languages are correct .. for example :

Usually you should not care about this, because the API only exposes the entries that match the users language setting on the server. cc @nickvergessen

@marinofaggiana
Copy link
Member

But I verify this or not ?

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 22, 2017

But I verify this or not ?

As far as I understood @nickvergessen you don't need to verify it. Just show all entries you get.

@nickvergessen
Copy link
Member

Just show all entries you get.

exactly. The API already filters. Just display what you get.

@marinofaggiana
Copy link
Member

ok.

@MorrisJobke
Copy link
Member Author

According to @marinofaggiana this is done.

@rakekniven rakekniven added this to the v2.17 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants