Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSXC icon only appears in admin settings, not in user settings #50

Closed
MarcelWaldvogel opened this issue Jul 28, 2017 · 8 comments
Closed
Milestone

Comments

@MarcelWaldvogel
Copy link
Contributor

MarcelWaldvogel commented Jul 28, 2017

A fix similar to 36a9d7a should be applied to the user settings as well

@sualko
Copy link
Member

sualko commented Jul 29, 2017

Sections are currently only supported in the admin settings by Nextcloud.

@sualko sualko closed this as completed Jul 29, 2017
@sualko sualko added the invalid label Jul 29, 2017
@MarcelWaldvogel
Copy link
Contributor Author

How come all the other parts (if they are not sections) have icons in NC12?
noicon

@sualko
Copy link
Member

sualko commented Jul 29, 2017 via email

@MarcelWaldvogel
Copy link
Contributor Author

Including the typo, this has not changed since 10.0: https://docs.nextcloud.com/server/10.0/developer_manual/app/settings.html

Also, e.g. federatedfilesharing already uses the new API: https://github.com/nextcloud/server/blame/master/apps/federatedfilesharing/lib/Settings/PersonalSection.php

So, I guess the documentation is just outdated. Let me open a ticket in nextcloud/server

@sualko
Copy link
Member

sualko commented Jul 29, 2017 via email

@MarcelWaldvogel
Copy link
Contributor Author

Which it was :-)

@sualko sualko removed the invalid label Jul 29, 2017
@sualko sualko reopened this Jul 29, 2017
@sualko sualko added this to the 3.3.0 milestone Jul 31, 2017
@sualko
Copy link
Member

sualko commented Jul 31, 2017

Ok, personal sections will be added in NC 13 and before they use css classes to inject icons. E.g. the jsxc entry has the class nav-icon-javascript-xmpp-client.

sualko added a commit that referenced this issue Jul 31, 2017
@sualko sualko closed this as completed in 9d7e9d8 Jul 31, 2017
@sualko
Copy link
Member

sualko commented Jul 31, 2017

screenshot from 2017-07-31 15-48-51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants