Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Fix styles location to they can be loaded #1042

Merged
merged 2 commits into from Nov 13, 2023
Merged

[stable27] Fix styles location to they can be loaded #1042

merged 2 commits into from Nov 13, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 11, 2023

@susnux
fix: Use correct output directory for styles so Nextcloud can load th…
a0d0de8 
…e styles correctly

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
f7d12e5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 27.1.4 milestone Nov 11, 2023
@susnux susnux mentioned this pull request Nov 11, 2023
Merged
@nickvergessen nickvergessen removed their request for review November 11, 2023 21:43
@blizzz blizzz requested review from Antreesy and removed request for blizzz November 13, 2023 10:56
Antreesy
Antreesy approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Seems to be working good, although i couldn't reproduce it for stable27 branch

@susnux susnux merged commit 83dd9a0 into stable27 Nov 13, 2023
25 checks passed
@susnux susnux deleted the fix/css-location branch November 13, 2023 14:10
@susnux susnux mentioned this pull request Nov 13, 2023
Closed
@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review bug feedback-requested regression
Projects
None yet
Milestone
Nextcloud 27.1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @Antreesy