Better handle when log_type isn't file and give explanation
#866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2023
icewind1991
force-pushed
the
jr-better-handle-non-file-log-types
branch
from
0932289
to
09ef630
Compare
Fixes nextcloud#52 (and possibly others) Currently if `log_type` is set to anything other than `file` (the default) - such as syslog or systemd - the Logging page spins indefinitely. This fixes the backend assumptions about logging always being log_type `file` and also provides the admin (user) with an informative message so they know what's going on. Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
jr-better-handle-non-file-log-types
branch
from
09ef630
to
09efbc0
Compare
I actually still see the logging page spinning indefinitely so I think there may have been a regression at some point. I'm on Nextcloud 27.1.3 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52 (and possibly others)
Currently if
log_typeis set to anything other thanfile(the default) - such as syslog or systemd - the Logging page spins indefinitely. This fixes the backend assumptions about logging always being log_typefileand also provides the admin (user) with an informative message so they know what's going on.Possible follow-up work: tidy up frontend, documentation additions