Execute units tests against php 8.1 & 8.2 #888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
868-execute-tests-againts-php8.2
branch
from
80a1672
to
eec27aa
Compare
Executes unit tests against more recent php versions on master and stable27 Resolves : #868 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
868-execute-tests-againts-php8.2
branch
from
eec27aa
to
7dd67de
Compare
susnux
requested changes
Jun 13, 2023
| @@ -39,7 +39,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| php-versions: ['8.0', '8.1', '8.2'] | |||
| server-versions: ['master'] | |||
| server-versions: ['master', 'stable27'] | |||
There was a problem hiding this comment.
Why stable27 this is only for the master branch, stable27 should only be tested on its own branch.
(so backporting this to stable27 instead)
There was a problem hiding this comment.
I think that is about adding 8.2 also to the stable27 branch.
nickvergessen
requested changes
Jun 19, 2023
There was a problem hiding this comment.
Basically #877 fixed master,
but the change should be either backported to stable27, or you manually add 8.2 to all phpunit-* files tehre
| @@ -38,8 +38,8 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| php-versions: ['8.0'] | |||
| server-versions: ['master'] | |||
| php-versions: ['8.0', '8.1', '8.2'] | |||
There was a problem hiding this comment.
this should also not be changed, to keep the CI matrix small.
|
Closing this with : #916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executes unit tests against more recent php versions on master and stable27
Resolves : #868