fix(outbox): add recipients check

Signed-off-by: Anna Larch <anna@nextcloud.com>

lib/Service/AntiAbuseService.php

@@ -26,6 +26,7 @@
 namespace OCA\Mail\Service;
 
 use OCA\Mail\AppInfo\Application;
+use OCA\Mail\Exception\ManyRecipientsException;
 use OCA\Mail\Model\NewMessageData;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\ICacheFactory;
@@ -58,8 +59,16 @@ public function __construct(IConfig $config,
 		$this->logger = $logger;
 	}
 
+	/**
+	 * @param IUser $user
+	 * @param NewMessageData $messageData
+	 * @return void
+	 * @throws ManyRecipientsException
+	 */
 	public function onBeforeMessageSent(IUser $user,
 		NewMessageData $messageData): void {
+		$this->checkNumberOfRecipients($user, $messageData);
+
 		$abuseDetection = $this->config->getAppValue(
 			Application::APP_ID,
 			'abuse_detection',
@@ -70,7 +79,6 @@ public function onBeforeMessageSent(IUser $user,
 			return;
 		}
 
-		$this->checkNumberOfRecipients($user, $messageData);
 		$this->checkRateLimits($user, $messageData);
 	}
 
@@ -79,7 +87,7 @@ private function checkNumberOfRecipients(IUser $user,
 		$numberOfRecipientsThreshold = (int)$this->config->getAppValue(
 			Application::APP_ID,
 			'abuse_number_of_recipients_per_message_threshold',
-			'0',
+			'15',
 		);
 		if ($numberOfRecipientsThreshold <= 1) {
 			return;
@@ -95,6 +103,7 @@ private function checkNumberOfRecipients(IUser $user,
 				'expected' => $numberOfRecipientsThreshold,
 				'actual' => $actualNumberOfRecipients,
 			]);
+			throw new ManyRecipientsException();
 		}
 	}