Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioning and LDAP #2566

Open
ksteinb opened this issue Jan 27, 2020 · 3 comments
Open

Provisioning and LDAP #2566

ksteinb opened this issue Jan 27, 2020 · 3 comments
Labels
1. to develop enhancement enterprise Features and bugs relevant for enterprise installations mostly help wanted

Comments

@ksteinb
Copy link

ksteinb commented Jan 27, 2020

Hi,

automatic provisioning does not work with LDAP, as %USERID% fetches the UID, which is usually a UUID Value and completly senseless for Email, instead with LDAP we need the DisplayName (which is the real user login Name).

so please add the patch below to make also a %DISPLAYNAME% parameter available.
``
*** Config.php.orig 2020-01-27 22:04:10.591445448 +0100
--- Config.php 2020-01-27 22:05:04.002460570 +0100


*** 112,118 ****
}

    /**

! * Replace %USERID% and %EMAIL% to allow special configurations
*
* @param string $original
* @param IUser $user
--- 112,118 ----
}

    /**

! * Replace %USERID%, %DISPLAYNAME% and %EMAIL% to allow special configurations
*
* @param string $original
* @param IUser $user


*** 122,127 ****
--- 122,130 ----
if ($user->getUID() !== null) {
$original = str_replace('%USERID%', $user->getUID(), $original);
}

  •             if ($user->getDisplayName() !== null) {
    
  •                     $original = str_replace('%DISPLAYNAME%', $user->getDisplayName(), $original);
    
  •             }
              if ($user->getEMailAddress() !== null) {
                      $original = str_replace('%EMAIL%', $user->getEMailAddress(), $original);
              }
    

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ksteinb
Copy link
Author

ksteinb commented Jan 27, 2020

Added comment : this is true in some cases, but not all, there should be also a way to get the login name used

@ChristophWurst
Copy link
Member

Please submit this as pull request.

@ksteinb
Copy link
Author

ksteinb commented Jan 28, 2020

Sorry, I'm a little bit old stylish ... but I prove to be able to learn ;-)

I just added a pull request

Sincerly,
Klaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement enterprise Features and bugs relevant for enterprise installations mostly help wanted
Projects
None yet
Development

No branches or pull requests

2 participants