Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic provisioning (for new users) #2403

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

ChristophWurst
Copy link
Member

This makes sure that every user has a provisioned account when Mail is accessed.

Before

new user didn't have provisioned account until admin provisioned for all users

After

also new users get their account as soon as they access the app

In the future we can use nextcloud/server#18348 to create the account right when the user is created. But it doesn't make a difference at the moment.

@ChristophWurst ChristophWurst added this to the next milestone Dec 19, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 19, 2019
@ChristophWurst ChristophWurst modified the milestones: 1.0.0, next Jan 17, 2020
@republicus
Copy link

Yes, please :)
I created a feature request issue at nextcloud/user_external that partially makes this request.
nextcloud/user_external#120 (comment)

Additionally, it would be useful if the user_external app were to also populate the user's email.

Mail app auto provision would be useful on a mail server with multiple domains by provisioning %EMAIL% instead of %USERID%@domain.com

That's already possible with provisioning. But, for other backend authentications, the email is not populated. So provisioning for multiple domains, while making use of %EMAIL%, doesn't work for for all backends.

@ChristophWurst
Copy link
Member Author

Additionally, it would be useful if the user_external app were to also populate the user's email.

Makes sense. Mind opening a feature request?

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/provision-account-automatically branch from b5b7ee0 to 528e66d Compare January 27, 2020 13:54
@ChristophWurst ChristophWurst merged commit dabe50a into master Jan 27, 2020
@ChristophWurst ChristophWurst deleted the fix/provision-account-automatically branch January 27, 2020 14:43
@republicus
Copy link

@ChristophWurst should the feature request you asked for be submitted in Mail?
The link I shared above is a feature request at nextcloud/user_external

I'm happy to reproduce it here if that is the right place for it.

PS. The automatic provisioning is working beautifully now.

@ChristophWurst
Copy link
Member Author

My mail server's logon username credentials is the user's full email -- so the user's email is already known and passed on the first login with user_external.

Possibly the same as #2566?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants