Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meatballs menu in the message list #3435

Open
Valdnet opened this issue Aug 11, 2020 · 6 comments
Open

Meatballs menu in the message list #3435

Valdnet opened this issue Aug 11, 2020 · 6 comments
Assignees

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Aug 11, 2020

Expected behavior

Correct operation of commands: "Unselect" and "Delete" in meatballs menu in the message list.

Actual behavior

  • After selecting "Select" and unchecking it again by "Unselect", the message is not deselected.
  • After selecting "Delete" the menu does not hide automatically. Only after clicking next to the menu.

obraz

In my opinion, the operation of the meatballs menu should be standardized, i.e. the principle of operation of all commands should work the same. When you click on a menu command, it should take an action and automatically hide.

Mail app

Mail app version: (see apps admin page, e.g. 0.5.3)
1.4.1

Server configuration

Nextcloud Version: (see admin page, e.g. 13.0.2)
19.0.0

Client configuration

Browser: (e.g. Firefox 48)
Firefox 79.0

Operating system: (e.g. Arch Linux)
Win10

@Valdnet Valdnet changed the title Hamburger menu in the message list Meatballs menu in the message list Aug 11, 2020
@ChristophWurst
Copy link
Member

👀 @StCyr

@StCyr
Copy link
Collaborator

StCyr commented Aug 11, 2020

I confirm the "Unselect bug" => unselect only work from the header bar (to unselect all emails)

@StCyr
Copy link
Collaborator

StCyr commented Aug 11, 2020

I can't confirm the "menu does not hide on delete action" bug. Could you please provide more details how to resimulate?

OTH, I have discovered a third bug: When you delete a selected envelope, the message is correctly deleted, but the next envelope gets automaticaly select, which shouldn't happen

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 11, 2020

Could you please provide more details how to resimulate?

Steps:

  1. Create a message in your draft.
  2. Click on Meatballs menu.
  3. Delete the message.

The menu does not hide automatically. Only after clicking next to the menu.
Deleting messages is also unstable.

@StCyr
Copy link
Collaborator

StCyr commented Aug 15, 2020

Unfortunately, mail's master branch only works on the upcoming NC20 and I have 19.0.1 installed.

I'll wait for NC20 to become available via the beta channel to proceed.

@StCyr StCyr self-assigned this Sep 2, 2020
@StCyr
Copy link
Collaborator

StCyr commented Sep 2, 2020

OK, I've fixed the 2 errors I've notices.

But the original reported error seems more related to issues in how route matching is done for draft messages.

For example:

When viewing https://nextcloud.acme.org/index.php/apps/mail/box/8/thread/new/12301 and trying to delete the message, the value of id in Mailbox.vue's onDelete method is new rather than 12301

Another example:

When opening the "Drafts" folder, the URL is set to https://nextcloud.acme.org/index.php/apps/mail/box/8/thread/12305 while I believe it should be set to https://nextcloud.acme.org/index.php/apps/mail/box/8/thread/new/12305

ChristophWurst added a commit that referenced this issue Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants