Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten table names and re-enable app code checker [$80 awarded] #784

Closed
5 tasks
ChristophWurst opened this issue Feb 15, 2018 · 6 comments
Closed
5 tasks

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Feb 15, 2018

Now that Nextcloud support database migration, it should be easy to shorten our table names to be app code checker compliant again.

To do:

  • DB migration class
  • Tests - if migrations are testable at all
  • Bump version number
  • Update docs that point to old table names
  • Re-enable app code checker on CI

The $80 bounty on this issue has been claimed at Bountysource.

@ChristophWurst ChristophWurst added this to the 0.7.11 milestone Feb 15, 2018
@ChristophWurst ChristophWurst self-assigned this Feb 15, 2018
@ChristophWurst ChristophWurst removed this from the 0.7.11 milestone Mar 28, 2018
@ChristophWurst ChristophWurst removed their assignment Mar 28, 2018
@ChristophWurst
Copy link
Member Author

Bummer, migrations don't allow table renaming

@jospoortvliet jospoortvliet changed the title Shorten table names and re-enable app code checker Shorten table names and re-enable app code checker [$15] Mar 28, 2018
@jospoortvliet jospoortvliet changed the title Shorten table names and re-enable app code checker [$15] Shorten table names and re-enable app code checker [$30] Mar 28, 2018
@nickvergessen
Copy link
Member

Bummer, migrations don't allow table renaming

Little trick:

  • Create new table
  • Copy everything over

https://github.com/nextcloud/spreed/blob/master/lib/Migration/Version2001Date20171026134605.phphttps://github.com/nextcloud/spreed/blob/master/lib/Migration/Version2001Date20171026134605.php

But yeah, could be simpler

@ChristophWurst
Copy link
Member Author

Little trick:

Create new table
Copy everything over

This is not a real solution for complex relations (e.g. tables that contain referenced primary keys).

https://github.com/nextcloud/spreed/blob/master/lib/Migration/Version2001Date20171026134605.phphttps://github.com/nextcloud/spreed/blob/master/lib/Migration/Version2001Date20171026134605.php

Dead link? 😉

@ChristophWurst
Copy link
Member Author

Thanks. I want to prevent this manual migration as far as possible as it's error-prone (keeping references and also not exhausting the available memory on larger instances).

@jospoortvliet jospoortvliet changed the title Shorten table names and re-enable app code checker [$30] Shorten table names and re-enable app code checker [$80] Aug 23, 2018
@ChristophWurst ChristophWurst added this to the 0.11.0 milestone Aug 28, 2018
@lock
Copy link

lock bot commented Nov 20, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@lock lock bot locked and limited conversation to collaborators Nov 20, 2018
@jospoortvliet jospoortvliet changed the title Shorten table names and re-enable app code checker [$80] Shorten table names and re-enable app code checker [$80 awarded] Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants