New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message delivery notification #4343
Conversation
lib/Db/MessageMapper.php
Outdated
@@ -560,6 +564,10 @@ public function findIdsByQuery(Mailbox $mailbox, SearchQuery $query, ?int $limit | |||
} | |||
} | |||
|
|||
if (isset($flags[Horde_Imap_Client::FLAG_MDNSENT])) { | |||
$select->andWhere($qb->expr()->eq('flag_mdnsent', $qb->createNamedParameter('flag_mdnsent', IQueryBuilder::PARAM_BOOL))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this flag to the array above at L550-558?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's just about the leading $
then we can maybe add 'mdnsent'
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely! Some smaller things
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise you will always see the button after a page refresh or navigating away any back 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increase the version to beta-3 in info.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, didn't give this the final test but will do so soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Fix #1467
Compose a new message
Message with mdn request