-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tagging to messages #4665
Add tagging to messages #4665
Conversation
e9066e9
to
9b38a13
Compare
38fed03
to
b00277e
Compare
aec19d5
to
63ff4c3
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d95ad67
to
88ee394
Compare
Can't find the requested changes
CI is partly failing because of codecov/codecov-action#234 |
d2362ce
to
bd185f2
Compare
in We need something similar to |
unless there is a change on master that we need here I would recommend to only do fixups and wait with the rebase until we have positive review & CI result. That will make it easier for me and others to check out the branch and pull the latest changes. |
dab7583
to
bf2bc3d
Compare
we have code that does To sum up we should index tags by their keyword. |
bf2bc3d
to
2f7785f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proper types and their documentation help developers, IDEs and static analysis :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
Now you may do the final rebase & squash done
88b2a36
to
57aeab9
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
57aeab9
to
83a5862
Compare
As discussed in #25