Fix active message selection #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state that determines whether a messages is actively shown or not is stored as a property of the message object. Since we now use the very same message data in the unified inbox as in specific ones, a message marked as being active kept its state when the users switched to the unified inbox. Now all states are reset to ensure we only have one active message. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Merged
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state that determines whether a messages is actively shown
or not is stored as a property of the message object. Since
we now use the very same message data in the unified inbox
as in specific ones, a message marked as being active kept its
state when the users switched to the unified inbox. Now all states
are reset to ensure we only have one active message.
Steps to reproduce the bug:
Fixes #466
cc @s-rosenfeld