Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error reporting during mail setup #5317

Conversation

CarlSchwan
Copy link
Member

Previously only the generic (and not useful) error message was
displayed when a more useful message was available and could have
been displayed instead.

The error message is located in error.data.message and not error.message

image

@welcome
Copy link

welcome bot commented Jul 12, 2021

Thanks for opening your first pull request in this repository! ✌️

@ChristophWurst
Copy link
Member

Thanks a lot.

I guess this then (at least partially) solves #3006.

src/views/Setup.vue Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

Now i remember that the message isn't always set. Did you try this with debug mode on or off? I think message is omitted in production mode.

@CarlSchwan
Copy link
Member Author

Now i remember that the message isn't always set. Did you try this with debug mode on or off? I think message is omitted in production mode.

I just tested with "debug" => false in my config.php and this particular message is still displayed.

@GretaD
Copy link
Contributor

GretaD commented Jul 13, 2021

On master, when you add wrong data you always get: Unexpected error during account creation

On this branch:
When i add the host but wrong pasword: Creating account failed:Connection to IMAP at mx.nextcloud.com:993 failed. Authentication failed.

when i "forget" to add the host: Creating account failed:Connection to IMAP at :993 failed. Error connecting to mail server.

So this is a great improvement already :)

@GretaD
Copy link
Contributor

GretaD commented Jul 13, 2021

You need to squash and sign your pr and its good to go

@CarlSchwan CarlSchwan force-pushed the work/carl/fix-setup-error-reporting branch from e753afe to a15d16c Compare July 13, 2021 14:25
@CarlSchwan
Copy link
Member Author

On master, when you add wrong data you always get: Unexpected error during account creation

On this branch:
When i add the host but wrong pasword: Creating account failed:Connection to IMAP at mx.nextcloud.com:993 failed. Authentication failed.

when i "forget" to add the host: Creating account failed:Connection to IMAP at :993 failed. Error connecting to mail server.

So this is a great improvement already :)

Thanks :)

Some wording could probably be improved but that's probably material for another MR :)

I squashed both commit and signed the MR.

Previously only the generic (and not usefull) error messages was
displayed when a more usefull message was available and could have
been displayed instead.

The error message is located in error.data.messsage and not error.message

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the work/carl/fix-setup-error-reporting branch from a15d16c to dca9c1b Compare July 13, 2021 14:35
@ChristophWurst ChristophWurst merged commit d989743 into nextcloud:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants