-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error reporting during mail setup #5317
Fix error reporting during mail setup #5317
Conversation
Thanks for opening your first pull request in this repository! ✌️ |
Thanks a lot. I guess this then (at least partially) solves #3006. |
Now i remember that the message isn't always set. Did you try this with debug mode on or off? I think message is omitted in production mode. |
I just tested with "debug" => false in my config.php and this particular message is still displayed. |
On master, when you add wrong data you always get: On this branch: when i "forget" to add the host: So this is a great improvement already :) |
You need to squash and sign your pr and its good to go |
e753afe
to
a15d16c
Compare
Thanks :) Some wording could probably be improved but that's probably material for another MR :) I squashed both commit and signed the MR. |
Previously only the generic (and not usefull) error messages was displayed when a more usefull message was available and could have been displayed instead. The error message is located in error.data.messsage and not error.message Signed-off-by: Carl Schwan <carl@carlschwan.eu>
a15d16c
to
dca9c1b
Compare
Previously only the generic (and not useful) error message was
displayed when a more useful message was available and could have
been displayed instead.
The error message is located in error.data.message and not error.message