Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.1 support #6131

Merged
merged 1 commit into from May 23, 2022
Merged

Add PHP8.1 support #6131

merged 1 commit into from May 23, 2022

Conversation

@ChristophWurst

This comment was marked as outdated.

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as outdated.

@ChristophWurst

This comment was marked as outdated.

@miaulalala
Copy link
Contributor

nextcloud/server#31212

FYI.

Detect encoding is not working as expected any longer, see php/php-src#8279

@st3iny
Copy link
Member

st3iny commented Apr 26, 2022

Detect encoding is not working as expected any longer, see php/php-src#8279

Damn, what can we do about it? Wait for an upstream patch of php?

PS: Also relevant php/php-src#8439

@come-nc
Copy link

come-nc commented Apr 26, 2022

Detect encoding is not working as expected any longer, see php/php-src#8279

Damn, what can we do about it? Wait for an upstream patch of php?

PS: Also relevant php/php-src#8439

You can use mb_check_encoding in a loop to get the same behavior as before from mb_detect_encoding.

@ChristophWurst

This comment was marked as outdated.

@ChristophWurst

This comment was marked as outdated.

@ChristophWurst
Copy link
Member Author

ChristophWurst commented May 13, 2022

assert($type instanceof Identifier || $type instanceof Name || $type instanceof ComplexType)
Script phpunit -c tests/phpunit.unit.xml --testdox --debug -v handling the test:unit event returned with error code 2

it now also fails locally when I run XDEBUG_MODE=coverage composer run test:unit

Related https://stackoverflow.com/questions/69793527/gitlab-testing-suddenly-get-error-with-symfony-project
https://github.com/sebastianbergmann/php-code-coverage/blob/3614a0f658bf1f10cf2dddfcb6e47a7ac5705a86/src/StaticAnalysis/CodeUnitFindingVisitor.php#L161

@ChristophWurst
Copy link
Member Author

New plan: disable coverage for PHP8.1 for now.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst marked this pull request as ready for review May 23, 2022 11:45
/**
* @return array
*/
#[ReturnTypeWillChange]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst ChristophWurst merged commit 63d774f into main May 23, 2022
@ChristophWurst ChristophWurst deleted the enhancement/php8.1 branch May 23, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants