Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ckeditor5-html-embed plugin #7427

Closed
wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

Rebased version of #7298.

Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Zupe007 <76497172+Zupe007@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

How it looks

Bildschirmfoto vom 2022-10-14 11-59-26

@AlexanderZuehr
Copy link

AlexanderZuehr commented Oct 19, 2022

@ChristophWurst
I dont know why it is so small in the beginning. It was the same for me.
I fixed it temporarily by using the Nextcloud CSS APP with

#select, button:not(.button-vue), input, textarea, div[contenteditable="true"], div[contenteditable="false"]{ width: unset; }

not it looks like this for me.
Signatur

I am not skilled enough to fix the standard behavior.

@ChristophWurst
Copy link
Member Author

I will have to discuss this with our designers then. I was under the impression that the HTML plugin would allow the users to edit the sources of the full message. Instead, it allows users to insert a block of HTML.

@ChristophWurst
Copy link
Member Author

@nimishavijay @jancborchardt what do you think about this change? The feature was briefly discussed in #7282.

@AlexanderZuehr
Copy link

AlexanderZuehr commented Oct 19, 2022

Yes it inserts a block. For my company that is exactly the feature we need and it is working quite good.
For Example:

Creating a signature.
Signatur anlegen

Writing an email, signature is added and shown perfectly.
Signatur in Mail

Also other users see the signature as intended.

I know that html signatures are not not very popular, but our company relies on it.

@AlexanderZuehr
Copy link

@ChristophWurst Hey, is there any chance my Pull request will be or maybe is accepted?

@technikfrek
Copy link

Is there any progress?
Me and my company are also interested in this feature.

Thanks in advance!

@ChristophWurst
Copy link
Member Author

Closing for now. I need designers to sign off this change. It still doesn't look like the right way to do this, sorry.

Ref #7427 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants