feat(deps): Add Nextcloud 28 support #8483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
|
needs info.xml update |
Yeah, I skipped it because you still want to send the final before that I guess. |
|
After #8482 the app will be branched off for 27 |
GretaD
force-pushed
the
update-main-version
branch
from
c3fc51d
to
644e2c7
Compare
GretaD
reviewed
May 17, 2023
appinfo/info.xml
Outdated
| @@ -30,7 +30,7 @@ | |||
| <screenshot>https://user-images.githubusercontent.com/1374172/79554966-278e1600-809f-11ea-82ea-7a0d72a2704f.png</screenshot> | |||
| <dependencies> | |||
| <php min-version="8.0" max-version="8.2" /> | |||
| <nextcloud min-version="26" max-version="27" /> | |||
| <nextcloud min-version="27" max-version="28" /> | |||
There was a problem hiding this comment.
now that im thinking, should i change the min-version to 27? or should i leave it 26?
There was a problem hiding this comment.
Leave 26 until it EOLs or we need a 27 API
Signed-off-by: Joas Schilling <coding@schilljs.com>
GretaD
force-pushed
the
update-main-version
branch
from
644e2c7
to
6cc4d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com