enh: add backend check for download permission for cloud attachements #9592
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
2. developing
3. to review
enhancement
skill:backend
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
enh/backend-check-for-download-permission
branch
from
3985509
to
0b875b4
Compare
st3iny
reviewed
May 10, 2024
There was a problem hiding this comment.
The backend side works. When sending the mail a warning is logged, the attachment is still shown in the frontend (composer) but not sent.
I wonder why the frontend let's me pick a file without download permissions. Shouldn't the file picker filter incoming shares without download permissions?
| $attributes = $share->getAttributes(); | ||
|
|
||
| if($attributes->getAttribute('permissions', 'download') === false) { | ||
| $this->logger->warning("Could not create attachment, no download permission for file: ${$attachment['fileName']}"); |
There was a problem hiding this comment.
Suggested change
| $this->logger->warning("Could not create attachment, no download permission for file: ${$attachment['fileName']}"); | |
| $this->logger->warning("Could not create attachment, no download permission for file: " . $attachment['fileName']); |
Array accesses inside string interpolations are not working.
|
they're supposed to be filtered out, it's a regression, I'm investigating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it silently Fails on draft/outbox save/update