Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar enhancements #1089

Merged
merged 3 commits into from Jul 2, 2023
Merged

Conversation

alaskanpuffin
Copy link
Contributor

@alaskanpuffin alaskanpuffin commented Jul 2, 2023

Fixes and improves the sidebar interface.

Changes

  • Fixes sidebar header icon. Now uses Nextcloud icons, because the svg api has been deprecated.
  • Standardizes styles and cleans up favorite form
  • Automatically closes sidebar on favorite delete
  • Confirmation messages for favorite form save/delete
  • Removes sidebar button from top right corner of map (it appears to do nothing and only opens a blank sidebar, but I could be missing something)

Updated Sidebar Layout

image

Confirmation Dialogs

image

image

@tacruc
Copy link
Collaborator

tacruc commented Jul 2, 2023

@alaskanpuffin thanks, why are there so many translation changes in the PR? Is it on purpose?

@alaskanpuffin
Copy link
Contributor Author

I merged master back into this branch, and it looks like it interpreted them as changes I made as opposed to a merge.

@tacruc
Copy link
Collaborator

tacruc commented Jul 2, 2023

Hm wired, there are apparently also conflicts with the Favorite Edition Form. Could you remove commit 0c92 and maybe rebase on master again?

@alaskanpuffin alaskanpuffin force-pushed the sidebar-enhancements branch 2 times, most recently from ad8da80 to 6745852 Compare July 2, 2023 16:53
Signed-off-by: Alaskan Puffin <alaskanpuffin@protonmail.com>
Signed-off-by: Alaskan Puffin <alaskanpuffin@protonmail.com>
Signed-off-by: Alaskan Puffin <alaskanpuffin@protonmail.com>
@tacruc tacruc merged commit f293510 into nextcloud:master Jul 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants